-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved display of log types. #753
Improved display of log types. #753
Conversation
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #753 +/- ##
==========================================
+ Coverage 31.28% 31.38% +0.10%
==========================================
Files 150 150
Lines 4913 4916 +3
Branches 880 881 +1
==========================================
+ Hits 1537 1543 +6
+ Misses 3192 3188 -4
- Partials 184 185 +1 |
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Haven't been able to reproduce locally the
|
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@amsiglan confirmed that the |
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.10 2.10
# Navigate to the new working tree
cd .worktrees/backport-2.10
# Create a new branch
git switch --create backport/backport-753-to-2.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7d90bb1301a3067164f4462291fa5a7d016b20e3
# Push it to GitHub
git push --set-upstream origin backport/backport-753-to-2.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.10 Then, create a pull request where the |
* Improved display of log types. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed cypress tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated cypress workflow. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed cypress tests. Fixed flyout. Fixed rule form. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated log type labels usage. Adjusted cypress tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit 7d90bb1)
* Improved display of log types. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed cypress tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated cypress workflow. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed cypress tests. Fixed flyout. Fixed rule form. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated log type labels usage. Adjusted cypress tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit 7d90bb1)
* Improved display of log types. (#753) * Improved display of log types. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed cypress tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated cypress workflow. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed cypress tests. Fixed flyout. Fixed rule form. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated log type labels usage. Adjusted cypress tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit 7d90bb1) * Update cypress-workflow.yml Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
* Improved display of log types. (#753) * Improved display of log types. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed cypress tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated cypress workflow. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed cypress tests. Fixed flyout. Fixed rule form. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated log type labels usage. Adjusted cypress tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated snapshots. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit 7d90bb1) * Update cypress-workflow.yml Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
Description
Refactored label displays for log types to capitalize text.
Issues Resolved
[List any issues this PR will resolve]
Screenshots
Create detector flow
Before
After
Create rule flow
Before
After
Log types table page
Before
After
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.